Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/fix osx arm make catch del kunit #253

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Bug/fix osx arm make catch del kunit #253

merged 2 commits into from
Nov 25, 2021

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Nov 25, 2021 •
edited
Loading

Removed Kunit and catch.hpp

Removed the header include/catch.hpp and kunit testing stub to fix Apple Silicon (darwin/arm64) builds

Note: follow up from #251

@sambles sambles added the bug label Nov 25, 2021
@sambles sambles mentioned this pull request Nov 25, 2021
Closed
hchagani-oasislmf
hchagani-oasislmf approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@hchagani-oasislmf hchagani-oasislmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass. I agree - kunit can be removed. Looks good.

@sambles sambles merged commit 06e54cd into develop Nov 25, 2021
@sambles sambles deleted the bug/fix-osx-arm-make-catch-del-kunit branch November 25, 2021 12:45
@awsbuild awsbuild added this to the v3.7.2 milestone Nov 25, 2021
@hchagani-oasislmf hchagani-oasislmf mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hchagani-oasislmf hchagani-oasislmf hchagani-oasislmf approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sambles @hchagani-oasislmf @awsbuild